Refactor buildDateTimeFormatter to return velox::Expected #11246
+210
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
rui-mo
reviewed
Oct 12, 2024
rui-mo
approved these changes
Oct 12, 2024
rui-mo
reviewed
Oct 12, 2024
| @@ -218,10 +218,10 @@ class DateTimeFormatter { | |||
| std::shared_ptr<DateTimeFormatter> buildMysqlDateTimeFormatter( | |||
| const std::string_view& format); | |||
There was a problem hiding this comment.
Should we also make this method return Expected for consistency?
There was a problem hiding this comment.
Of course. Updated.
|
@mbasmanova Could you take a look please? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently introduced velox::Expected (#9858) to use in non-void no-throw APIs. It's more proper to return that.