Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix in HashBuild operator #11234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Typo fix in HashBuild operator #11234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion velox/exec/HashBuild.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ HashBuild::HashBuild(

joinBridge_->addBuilder();

auto inputType = joinNode_->sources()[1]->outputType();
const auto& inputType = joinNode_->sources()[1]->outputType();

const auto numKeys = joinNode_->rightKeys().size();
keyChannels_.reserve(numKeys);
Expand Down
2 changes: 1 addition & 1 deletion velox/exec/HashBuild.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace facebook::velox::exec {
// Builds a hash table for use in HashProbe. This is the final
// Operator in a build side Driver. The build side pipeline has
// multiple Drivers, each with its own HashBuild. The build finishes
// when the last Driver of the build pipeline finishes. Hence finish()
// when the last Driver of the build pipeline finishes. Hence finishHashBuild()
// has a barrier where the last one to enter gathers the data
// accumulated by the other Drivers and makes the join hash
// table. This table is then passed to the probe side pipeline via
Expand Down
Loading