Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the flag of Arrow MapVector to not-nullable in Bridge.cpp #11214

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set the flag of Arrow MapVector to not-nullable in Bridge.cpp #11214

wants to merge 2 commits into from
+15 −1

Conversation

whutjs
Copy link

@whutjs whutjs commented Oct 10, 2024

See #11204

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit edd660c
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/670899bc5ade4a00080af72f

Yuhta
Yuhta reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Yuhta Yuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test for this as well?

@whutjs
Copy link
Author

whutjs commented Oct 11, 2024

@Yuhta thanks for your review. I add some assertions in the ArrowBridgeSchemaTest to verify that the flag of MapVector should not be nullable.

@whutjs whutjs closed this Oct 11, 2024
@whutjs whutjs reopened this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whutjs @Yuhta @facebook-github-bot