-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCS credential config and rename to hive.gcs.json-key-file-path #11086
Conversation
✅ Deploy Preview for meta-velox canceled.
|
@tigrux do you have any feedback on this? |
Thanks for taking care of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change!
Hi @majetideepak, there seems to be a build error from GCSFileSystemTest.cpp in the failed CI job (https://github.com/facebookincubator/velox/actions/runs/11033835431/job/30645931332?pr=11086). Could you take a look? |
fc99669
to
5193871
Compare
@kagamiori GCSFileSystemTest on CI is now passing. Thanks! |
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kagamiori merged this pull request in fcc1b1c. |
Conbench analyzed the 1 benchmark run on commit There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Current
hive.gcs.credentials
expects a JSON string with the GCS service account configuration.However, this JSON string is expected to be unescaped by the google C++ SDK. It is not possible to pass an unescaped JSON string via a config file.
The norm seems to specify a file path with the service account configuration.
Presto uses
hive.gcs.json-key-file-path
. Velox will use the same.https://github.com/prestodb/presto/blob/62ca0801fba8448b162fe89f8dab10e0c14158e1/presto-docs/src/main/sphinx/release/release-0.225.rst#hive-changes