Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out "Add Findstemmer.cmake to find lib stemmer" #10965

Closed
wants to merge 1 commit into from

Conversation

kgpai
Copy link
Contributor

@kgpai kgpai commented Sep 11, 2024

Summary:
Reverting PR #10884 due to it breaking PyVelox builds and Fuzzer .
Fixes issue : #10963

Original commit changeset: dec13d672129

Original Phabricator Diff: D62373662

Reviewed By: amitkdutta

Differential Revision: D62477240

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a12c4ec
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66e119030749c40008b5902a

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62477240

…or#10965)

Summary:
Pull Request resolved: facebookincubator#10965

Reverting PR facebookincubator#10884 due to it breaking PyVelox builds and Fuzzer .
Fixes issue : facebookincubator#10963

Original commit changeset: dec13d672129

Original Phabricator Diff: D62373662

Reviewed By: xiaoxmeng, amitkdutta, kagamiori

Differential Revision: D62477240
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62477240

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 485329e.

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2024
Summary:
The early merged pr (38f9a1f) was reverted by #10965 due to this issue: #10963.

In the original impl., a patch is expected to be applied to add `-fPIC` before building lib
stemmer, but when building docker image (ghcr.io/facebookincubator/velox-dev:centos9),
that patch file is not available to use due to the copied setup script outside velox repo is
executed. See code:
https://github.com/facebookincubator/velox/blob/7f2d7adaa1544c72129fd1c8d0766755ff354455/scripts/centos.dockerfile#L22
This pr proposes the installation of lib stemmer with the above issue fixed.

Pull Request resolved: #10984

Reviewed By: DanielHunte

Differential Revision: D63344087

Pulled By: Yuhta

fbshipit-source-id: a1467f5392ef828efdd219d0b7f1dfe0003d00ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants