Fix parsing array struct when repetition_type is 'REPEATED' #10753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Aug 14, 2024
yma11
changed the title
Updated. But seems data read also have some problems. Let me do try a further fix. |
|
@Yuhta Fixed. Please help review again. Thanks. |
yma11
changed the title
yma11
force-pushed
the
array-struct
branch
2 times, most recently
from
b345f25
to
ca70196
Compare
Yuhta
approved these changes
Aug 23, 2024
Yuhta
added
the
ready-to-merge
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 2, 2024
…incubator#10753) Summary: Velox fails to parse array struct in attached example file as it doesn't consider `RowType` in when `repetition_type` is `REPEATED`. Pull Request resolved: facebookincubator#10753 Reviewed By: Yuhta Differential Revision: D61862384 Pulled By: kgpai fbshipit-source-id: c15338630a0a952acc80be6c2e91857e42cb9350
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 3, 2024
…incubator#10753) Summary: Velox fails to parse array struct in attached example file as it doesn't consider `RowType` in when `repetition_type` is `REPEATED`. Pull Request resolved: facebookincubator#10753 Reviewed By: Yuhta Differential Revision: D61862384 Pulled By: kgpai fbshipit-source-id: c15338630a0a952acc80be6c2e91857e42cb9350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Velox fails to parse array struct in attached example file as it doesn't consider
RowTypein whenrepetition_typeisREPEATED.