Back out "Fix Iceberg read when positional delete files are unaligned" #10431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Original commit changeset: 368101d306d7 Original Phabricator Diff: D59350780 Differential Revision: D59569005
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D59569005 |
6 tasks
gggrace14
approved these changes
Jul 10, 2024
amitkdutta
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Thanks @tanjialiang. Can you add a reason for the backout or any reference to open issues/failed PR that is blocked?
|
This pull request has been merged in e8a73ae. |
|
CC: @yingsu00 |
|
@tanjialiang Can you please provide what test failure it tried to resolve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: 368101d306d7
Original Phabricator Diff: D59350780
Differential Revision: D59569005
Offending PR identified by @zacw7. Backing out to resolve E2E test failure.