Fix raw bytes read in DirectBufferedInput #10266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The calculation of raw bytes and storage read bytes are wrong in `DirectBufferedInput` Differential Revision: D58818252
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D58818252 |
|
Thanks @Yuhta. Is it a recent regression or existing issue? |
amitkdutta
approved these changes
Jun 20, 2024
spershin
approved these changes
Jun 20, 2024
|
@amitkdutta It's a regression caused by #9801. The values before that were not correct either but there was no negative. |
|
This pull request has been merged in a605b90. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The calculation of raw bytes and storage read bytes are wrong in
DirectBufferedInputDifferential Revision: D58818252