Remove EXACT protobuf dependency on 3.21.4

[karteekmurthys]

Fixes: #10112

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	4e0d55e
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/666352690c6f1f0008095a1f

[assignUser]

This does not actually fix the issue, it just circumvents building protobuf from scratch. As I mentioned in the issue I am not sure if we still need the exact pin, so the change might be ok in general but I can't judge that.

[karteekmurthys]

This does not actually fix the issue, it just circumvents building protobuf from scratch. As I mentioned in the issue I am not sure if we still need the exact pin, so the change might be ok in general but I can't judge that.

@kgpai let me know if this change to mark EXACT required or can we remove it.

-- Could NOT find Protobuf: Found unsuitable version "3.21.12", but required is exact version "3.21.4" (found /opt/homebrew/lib/libprotobuf.dylib)
-- Building Protobuf from source
-- 
-- 3.21.4.0
-- Using BUNDLED Protobuf
-- Setting simdjson source to AUTO

[majetideepak]

We still need 3.21 as 3.22 onwards has breaking changes afaik.
Will using resolve_dependency(Protobuf 3.21 EXACT) help?

[assignUser]

As we bumped the cmake version we can now use a range:

A version range with the format versionMin...[<]versionMax where versionMin and versionMax have the same format and constraints on components being integers as the single version. By default, both end points are included. By specifying <, the upper end point will be excluded. Version ranges are only supported with CMake 3.19 or later.

So resolve_dependency(Protobuf 3...<4) should work as v22 is actually 4.22

Edit: it also might be good to confirm that we actually not compatible with 22+ ^^

[majetideepak]

So resolve_dependency(Protobuf 3...<4) should work as v22 is actually

The quick fix for now is to use this. I agree that we should confirm support for v22+. I will try that after we move to Centos9.

[majetideepak]

I also see a security issue against 3.21.4. We should update the minimum version to 3.21.7. #3136.

[assignUser]

#10133 I'll open a PR with the version range and minversion bump

[assignUser]

@karteekmurthys this should fix your issue, could you confirm? #10134