Remove parseDateString function #10094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D58182255
Differential Revision: D58256397
Differential Revision: D58258211
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D58260593 |
|
This pull request was exported from Phabricator. Differential Revision: D58260593 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Jun 6, 2024
Summary: Pull Request resolved: facebookincubator#10094 Remove fromDateString function. Rename castFromDateString to fromDateString. This makes it consistent with fromTimestampString. Differential Revision: D58260593
mbasmanova
force-pushed
the
export-D58260593
branch
from
7113b86
to
a8efd9d
Compare
Summary: Pull Request resolved: facebookincubator#10094 Remove fromDateString function. Rename castFromDateString to fromDateString. This makes it consistent with fromTimestampString. Differential Revision: D58260593
|
This pull request was exported from Phabricator. Differential Revision: D58260593 |
mbasmanova
force-pushed
the
export-D58260593
branch
from
a8efd9d
to
b90f886
Compare
|
This pull request has been merged in d9d730c. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#10094 Remove fromDateString function. Rename castFromDateString to fromDateString. This makes it consistent with fromTimestampString. Reviewed By: xiaoxmeng Differential Revision: D58260593 fbshipit-source-id: cec60fc11e90faeba9879fa1bf7a1b52d5cee3ff
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#10094 Remove fromDateString function. Rename castFromDateString to fromDateString. This makes it consistent with fromTimestampString. Reviewed By: xiaoxmeng Differential Revision: D58260593 fbshipit-source-id: cec60fc11e90faeba9879fa1bf7a1b52d5cee3ff
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: facebookincubator#10094 Remove fromDateString function. Rename castFromDateString to fromDateString. This makes it consistent with fromTimestampString. Reviewed By: xiaoxmeng Differential Revision: D58260593 fbshipit-source-id: cec60fc11e90faeba9879fa1bf7a1b52d5cee3ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove fromDateString function. Rename castFromDateString to fromDateString. This makes it consistent with fromTimestampString.
Differential Revision: D58260593