Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatVector<bool>::copy crashes when source has null values buffer #6611

Closed
mbasmanova opened this issue Sep 18, 2023 · 0 comments
Closed

FlatVector<bool>::copy crashes when source has null values buffer #6611

mbasmanova opened this issue Sep 18, 2023 · 0 comments
Labels
bug Something isn't working triage Newly created issue that needs attention.

Comments

@mbasmanova
Copy link
Contributor

Bug description

FlatVector::copy crashes when 'source' vector is a FlatVector with null values buffer (i.e. all values are null).

The crash is due to FlatVector::copyValuesAndNulls not checking is source's values buffer is null.

CC: @xiaoxmeng @laithsakka @kevinwilfong @kagamiori @kgpai

System information

n/a

Relevant logs

No response
@mbasmanova mbasmanova added bug Something isn't working triage Newly created issue that needs attention. labels Sep 18, 2023
@mbasmanova mbasmanova mentioned this issue Sep 18, 2023
Closed
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
0110733 
Summary:
Fixes facebookincubator#6611

FlatVector<T>::copyValuesAndNulls has a good amount of intricate logic to handle various corner cases. FlatVector<bool>::copyValuesAndNulls specialization needs to be copy all that logic and inevitable some of it is missed. Remove specialization for bool type to avoid future bugs.


Differential Revision: D49362420

Pulled By: mbasmanova
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
7e049d3 
Summary:
Fixes facebookincubator#6611

Pull Request resolved: facebookincubator#6613

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 9ffe02cc362fddfd2382fe1995fbe9be8ed04e28
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
2857dff 
Summary:
Fixes facebookincubator#6611

Pull Request resolved: facebookincubator#6613

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 8be6e37dca63ededfab8d88e7bea0007bcf72854
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
8aa0462 
Summary:
Fixes facebookincubator#6611

FlatVector<T>::copyValuesAndNulls has a good amount of intricate logic to handle
various corner cases. FlatVector<bool>::copyValuesAndNulls specialization needs
to be copy all that logic and inevitable some of it is missed. Remove
specialization for bool type to avoid future bugs.


Reviewed By: laithsakka

Differential Revision: D49362420

Pulled By: mbasmanova
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
c4cbd34 
Summary:
Fixes facebookincubator#6611

Pull Request resolved: facebookincubator#6613

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: de990f42bbeeec2dd5f79664963cadb0d23feef4
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
6f13d47 
Summary:
Fixes facebookincubator#6611

Pull Request resolved: facebookincubator#6613

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 5a78e1982b2607c400794a61cf368ab4f644d749
mbasmanova added a commit to mbasmanova/velox-1 that referenced this issue Sep 18, 2023
@mbasmanova @facebook-github-bot
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
e36aacd 
Summary:
Fixes facebookincubator#6611

Pull Request resolved: facebookincubator#6613

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 3a078482708573d490f8a6d30e63667a96009ae8
codyschierbeck pushed a commit to codyschierbeck/velox that referenced this issue Sep 27, 2023
@mbasmanova @codyschierbeck
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
41a876b 
Summary:
Fixes facebookincubator#6611

FlatVector<T>::copyValuesAndNulls has a good amount of intricate logic to handle
various corner cases. FlatVector<bool>::copyValuesAndNulls specialization needs
to be copy all that logic and inevitable some of it is missed. Remove
specialization for bool type to avoid future bugs.

Pull Request resolved: facebookincubator#6613

Reviewed By: laithsakka

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 70c661d43373cade7984500ecf912b28400dbf7f
codyschierbeck pushed a commit to codyschierbeck/velox that referenced this issue Sep 27, 2023
@mbasmanova @codyschierbeck
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
20df24e 
Summary:
Fixes facebookincubator#6611

FlatVector<T>::copyValuesAndNulls has a good amount of intricate logic to handle
various corner cases. FlatVector<bool>::copyValuesAndNulls specialization needs
to be copy all that logic and inevitable some of it is missed. Remove
specialization for bool type to avoid future bugs.

Pull Request resolved: facebookincubator#6613

Reviewed By: laithsakka

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 70c661d43373cade7984500ecf912b28400dbf7f
codyschierbeck pushed a commit to codyschierbeck/velox that referenced this issue Sep 27, 2023
@mbasmanova @codyschierbeck
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
8b32669 
Summary:
Fixes facebookincubator#6611

FlatVector<T>::copyValuesAndNulls has a good amount of intricate logic to handle
various corner cases. FlatVector<bool>::copyValuesAndNulls specialization needs
to be copy all that logic and inevitable some of it is missed. Remove
specialization for bool type to avoid future bugs.

Pull Request resolved: facebookincubator#6613

Reviewed By: laithsakka

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 70c661d43373cade7984500ecf912b28400dbf7f
ericyuliu pushed a commit to ericyuliu/velox that referenced this issue Oct 12, 2023
@mbasmanova @ericyuliu
Fix crash in FlatVector<bool>::copy (facebookincubator#6613)
79999fa 
Summary:
Fixes facebookincubator#6611

FlatVector<T>::copyValuesAndNulls has a good amount of intricate logic to handle
various corner cases. FlatVector<bool>::copyValuesAndNulls specialization needs
to be copy all that logic and inevitable some of it is missed. Remove
specialization for bool type to avoid future bugs.

Pull Request resolved: facebookincubator#6613

Reviewed By: laithsakka

Differential Revision: D49362420

Pulled By: mbasmanova

fbshipit-source-id: 70c661d43373cade7984500ecf912b28400dbf7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Newly created issue that needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash in FlatVector<bool>::copy mbasmanova/velox-1
1 participant
@mbasmanova