address comments

facebookincubator · Sep 14, 2024 · fea5906 · fea5906
1 parent fe9581b
commit fea5906
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/velox/core/SimpleFunctionMetadata.h b/velox/core/SimpleFunctionMetadata.h
@@ -394,6 +394,7 @@ class ISimpleFunctionMetadata {
   virtual bool physicalSignatureEquals(
       const ISimpleFunctionMetadata& other) const = 0;
   virtual std::string helpMessage(const std::string& name) const = 0;
+  virtual std::string toString(const std::string& name) const = 0;
 };
 
 template <typename T, typename = int32_t>
@@ -516,6 +517,27 @@ class SimpleFunctionMetadata : public ISimpleFunctionMetadata {
   }
 
   std::string helpMessage(const std::string& name) const final {
+    // return fmt::format("{}({})", name, signature_->toString());
+    std::string s{name};
+    s.append("(");
+    bool first = true;
+    for (auto& arg : signature_->argumentTypes()) {
+      if (!first) {
+        s.append(", ");
+      }
+      first = false;
+      s.append(boost::algorithm::to_upper_copy(arg.toString()));
+    }
+
+    if (isVariadic()) {
+      s.append("...");
+    }
+
+    s.append(")");
+    return s;
+  }
+
+  std::string toString(const std::string& name) const final {
     std::stringstream sig;
     bool first = true;
     for (auto& arg : signature_->argumentTypes()) {

diff --git a/velox/expression/SimpleFunctionRegistry.h b/velox/expression/SimpleFunctionRegistry.h
@@ -132,6 +132,10 @@ class SimpleFunctionRegistry {
       return functionEntry_.getMetadata().helpMessage(name);
     }
 
+    std::string toString(const std::string& name) const {
+      return functionEntry_.getMetadata().toString(name);
+    }
+
     VectorFunctionMetadata metadata() const {
       return VectorFunctionMetadata{
           false,

diff --git a/velox/expression/tests/SimpleFunctionTest.cpp b/velox/expression/tests/SimpleFunctionTest.cpp
@@ -1642,7 +1642,7 @@ TEST_F(SimpleFunctionTest, helpMessage) {
       functionName, {DECIMAL(20, 2), BIGINT()});
   EXPECT_TRUE(function.has_value());
   EXPECT_EQ(
-      function.value().helpMessage(functionName),
+      function.value().toString(functionName),
       "FunctionName: decimal_plus_value\nSignature argument types:\nDECIMAL(I1,I5), BIGINT\n"
       "Physical argument types:\nHUGEINT, BIGINT\nPhysical result types:\nHUGEINT\n"
       "Priority:999997\nDefaultNullBehavior:true");