Skip to content

Commit

Permalink
minor change
Browse files Browse the repository at this point in the history
  • Loading branch information
zhli1142015 committed Sep 29, 2024
1 parent 85eb7f0 commit a7c70e8
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions velox/exec/tests/HashJoinTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8186,7 +8186,8 @@ TEST_F(HashJoinTest, combineSmallVectorsAfterFilter) {
return makeRowVector(
{"t0", "t1"},
{
makeFlatVector<int32_t>(1'000, [](auto row) { return row; }),
makeFlatVector<int32_t>(
1'000, [](auto row) { return row; }, nullEvery(400)),
makeFlatVector<int64_t>(1'000, [](auto row) { return row * 10; }),
});
});
Expand All @@ -8196,7 +8197,9 @@ TEST_F(HashJoinTest, combineSmallVectorsAfterFilter) {
{"u0", "u1"},
{
makeFlatVector<int32_t>(
1'000, [](auto row) { return -100 + (row / 5); }),
1'000,
[](auto row) { return -100 + (row / 5); },
nullEvery(300)),
makeFlatVector<int64_t>(
1'000, [](auto row) { return -1000 + (row / 5) * 10; }),
});
Expand Down Expand Up @@ -8297,7 +8300,7 @@ TEST_F(HashJoinTest, combineSmallVectorsAfterFilter) {
verifyJoinOutputVectorCount(
1, // 3 output vectors are merged to 1 vector.
core::JoinType::kLeftSemiProject,
"SELECT t0, t1, t0 IN (SELECT u0 FROM u WHERE (t1 + u1) % 3 = 0) FROM t");
"SELECT t0, t1, EXISTS (SELECT u0 FROM u WHERE t0 = u0 AND (t1 + u1) % 3 = 0) FROM t");
verifyJoinOutputVectorCount(
1, // 3 output vectors are merged to 1 vector.
core::JoinType::kLeftSemiProject,
Expand All @@ -8306,7 +8309,7 @@ TEST_F(HashJoinTest, combineSmallVectorsAfterFilter) {
verifyJoinOutputVectorCount(
1, // 3 output vectors are merged to 1 vector.
core::JoinType::kLeftSemiProject, // Flip join side.
"SELECT t0, t1, t0 IN (SELECT u0 FROM u WHERE (t1 + u1) % 3 = 0) FROM t",
"SELECT t0, t1, EXISTS (SELECT u0 FROM u WHERE t0 = u0 AND (t1 + u1) % 3 = 0) FROM t",
false,
true);
}
Expand All @@ -8328,11 +8331,11 @@ TEST_F(HashJoinTest, combineSmallVectorsAfterFilter) {
verifyJoinOutputVectorCount(
1, // 3 output vectors are merged to 1 vector.
core::JoinType::kAnti,
"SELECT t0, t1, FROM t WHERE NOT EXISTS (SELECT * FROM u WHERE t0 = u0 AND (t1 + u1) % 3 = 0)");
"SELECT t0, t1 FROM t WHERE NOT EXISTS (SELECT * FROM u WHERE t0 = u0 AND (t1 + u1) % 3 = 0)");
verifyJoinOutputVectorCount(
1, // 2 output vectors are merged to 1 vector.
core::JoinType::kAnti,
"SELECT t0, t1, FROM t WHERE NOT EXISTS (SELECT * FROM u WHERE t0 = u0 AND (t1 + u1) % 3 = 0)",
"SELECT t0, t1 FROM t WHERE t0 NOT IN (SELECT u0 FROM u WHERE (t1 + u1) % 3 = 0)",
true);
}
}
Expand Down

0 comments on commit a7c70e8

Please sign in to comment.