Skip to content

Commit

Permalink
Add check in computeIsAsciiForInputs (#7032)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #7032

For some reason the check seems to silence the CircleCI error!
there is several seg faults in fuzzer where debugging showed that vector is null!
#7009

The problem could be a generic memory corruption, hope that this check might
make it more verbose.

Reviewed By: kgpai

Differential Revision: D50245829

fbshipit-source-id: b4188ec88531849d0f8ab4a049b717ceb122bc5a
  • Loading branch information
laithsakka authored and facebook-github-bot committed Oct 16, 2023
1 parent 9314277 commit 7d3d216
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions velox/expression/Expr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,8 @@ void computeIsAsciiForInputs(
inputValues[index]->type()->kind() == TypeKind::VARCHAR) {
auto* vector =
inputValues[index]->template as<SimpleVector<StringView>>();

VELOX_CHECK(vector);
vector->computeAndSetIsAscii(rows);
}
}
Expand Down

0 comments on commit 7d3d216

Please sign in to comment.