Skip to content

Commit

Permalink
fix(tpch): Fix TPCH benchmark reader crash (#11833)
Browse files Browse the repository at this point in the history
Summary:
This PR fixes the tpch benchmark crash after new parquet and dwrf readers added.
parquet and dwrf reader are registered in benchmark initialize.
Tested by running query 1 to 22 on SF10 data, format parquet.

Pull Request resolved: #11833

Reviewed By: xiaoxmeng, DanielHunte

Differential Revision: D67675533

Pulled By: pedroerp

fbshipit-source-id: 2a8fa5c2f3f6a3d6524141d56489530000855810
  • Loading branch information
karthikeyann authored and facebook-github-bot committed Dec 27, 2024
1 parent c046524 commit 691de01
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions velox/benchmarks/QueryBenchmarkBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ void QueryBenchmarkBase::initialize() {
connector::hive::HiveConnectorFactory::kHiveConnectorName)
->newConnector(kHiveConnectorId, properties, ioExecutor_.get());
connector::registerConnector(hiveConnector);
parquet::registerParquetReaderFactory();
dwrf::registerDwrfReaderFactory();
}

std::vector<std::shared_ptr<connector::ConnectorSplit>>
Expand Down
2 changes: 2 additions & 0 deletions velox/benchmarks/QueryBenchmarkBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
#include "velox/connectors/hive/HiveConfig.h"
#include "velox/connectors/hive/HiveConnector.h"
#include "velox/dwio/common/Options.h"
#include "velox/dwio/dwrf/RegisterDwrfReader.h"
#include "velox/dwio/parquet/RegisterParquetReader.h"
#include "velox/exec/PlanNodeStats.h"
#include "velox/exec/Split.h"
#include "velox/exec/tests/utils/HiveConnectorTestBase.h"
Expand Down

0 comments on commit 691de01

Please sign in to comment.