Add fetchMetrics API to BaseStatsReporter

facebookincubator · Jun 13, 2024 · 22ecbe6 · 22ecbe6
1 parent 08e0b30
commit 22ecbe6
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/velox/common/base/StatsReporter.h b/velox/common/base/StatsReporter.h
@@ -135,6 +135,9 @@ class BaseStatsReporter {
   virtual void addHistogramMetricValue(folly::StringPiece key, size_t value)
       const = 0;
 
+  /// Return the metrics in a serialized string format.
+  virtual std::string fetchMetrics() const = 0;
+
   static bool registered;
 };
 
@@ -179,6 +182,8 @@ class DummyStatsReporter : public BaseStatsReporter {
 
   void addHistogramMetricValue(folly::StringPiece /* key */, size_t /* value */)
       const override {}
+
+  std::string fetchMetrics() const override { return ""; }
 };
 
 #define DEFINE_METRIC(key, type)                               \