Skip to content

Commit

Permalink
Fix overflow in FloatingPointColumnReader::skip (#9046)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #9046

Title

Reviewed By: Yuhta, ninginthecloud

Differential Revision: D54790781

fbshipit-source-id: 5a52ebcfc2ae7397f34e26b4000f54c3a634297e
  • Loading branch information
Patrick Sullivan authored and facebook-github-bot committed Mar 12, 2024
1 parent a108c70 commit 17de646
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/dwio/dwrf/reader/ColumnReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ uint64_t FloatingPointColumnReader<DataT, ReqT>::skip(uint64_t numValues) {
if (remaining >= toSkip) {
bufferPointer += toSkip;
} else {
inputStream->Skip(static_cast<int32_t>(toSkip - remaining));
inputStream->SkipInt64(toSkip - remaining);
bufferEnd = nullptr;
bufferPointer = nullptr;
}
Expand Down

0 comments on commit 17de646

Please sign in to comment.