Add sessionTimezone and adjustTimestampToTimezone to DWRF reader and …

…writer options
facebookincubator · Sep 27, 2024 · 05a1673 · 05a1673
1 parent f099582
commit 05a1673
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/velox/dwio/dwrf/reader/ReaderBase.cpp b/velox/dwio/dwrf/reader/ReaderBase.cpp
@@ -76,6 +76,12 @@ FooterStatisticsImpl::FooterStatisticsImpl(
   }
 }
 
+ReaderBase::ReaderBase(
+    MemoryPool& pool,
+    std::unique_ptr<dwio::common::BufferedInput> input,
+    FileFormat fileFormat)
+    : ReaderBase(createReaderOptions(pool, fileFormat), std::move(input)) {}
+
 ReaderBase::ReaderBase(
     const dwio::common::ReaderOptions& options,
     std::unique_ptr<dwio::common::BufferedInput> input)

diff --git a/velox/dwio/dwrf/reader/ReaderBase.h b/velox/dwio/dwrf/reader/ReaderBase.h
@@ -65,6 +65,13 @@ class ReaderBase {
       const dwio::common::ReaderOptions& options,
       std::unique_ptr<dwio::common::BufferedInput> input);
 
+  /// Creates reader base from buffered input.
+  /// It is kept here for backward compatibility with Meta's internal usage.
+  ReaderBase(
+      memory::MemoryPool& pool,
+      std::unique_ptr<dwio::common::BufferedInput> input,
+      dwio::common::FileFormat fileFormat);
+
   /// Creates reader base from metadata.
   ReaderBase(
       memory::MemoryPool& pool,
@@ -245,6 +252,14 @@ class ReaderBase {
       uint32_t index = 0,
       bool fileColumnNamesReadAsLowerCase = false);
 
+  static dwio::common::ReaderOptions createReaderOptions(
+      memory::MemoryPool& pool,
+      dwio::common::FileFormat fileFormat) {
+    dwio::common::ReaderOptions options(&pool);
+    options.setFileFormat(fileFormat);
+    return options;
+  }
+
   const dwio::common::ReaderOptions options_;
   std::unique_ptr<google::protobuf::Arena> arena_;
   std::unique_ptr<PostScript> postScript_;