fix: Reuse vector in LocalPartition #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: More than 10% of the CPU are spent on the destruction of local partition output when the load is high. Also add some optimizations for serialization. Differential Revision: D67742489
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67742489 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Jan 2, 2025
Summary: X-link: facebookincubator/nimble#122 More than 10% of the CPU are spent on the destruction of local partition output when the load is high. Also add some optimizations for serialization. Optimization on `ByteOutputStream::appendOneBool` does not show significant gain in the query in example (because they are a lot small batches), but it is net gain and would be significant in large batches, so I leave it in the code. Differential Revision: D67742489
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Jan 10, 2025
Summary: X-link: facebookincubator/nimble#122 More than 10% of the CPU are spent on the destruction of local partition output when the load is high. Also add some optimizations for serialization. Optimization on `ByteOutputStream::appendBool` does not show significant gain in the query in example (because they are a lot small batches), but it is net gain and would be significant in large batches, so I leave it in the code. Differential Revision: D67742489
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Jan 10, 2025
Summary: X-link: facebookincubator/nimble#122 More than 10% of the CPU are spent on the destruction of local partition output when the load is high. Also add some optimizations for serialization. Optimization on `ByteOutputStream::appendBool` does not show significant gain in the query in example (because they are a lot small batches), but it is net gain and would be significant in large batches, so I leave it in the code. Differential Revision: D67742489
|
This pull request has been merged in f858d12. |
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: #12002 X-link: facebookincubator/nimble#122 More than 10% of the CPU are spent on the destruction of local partition output when the load is high. Also add some optimizations for serialization. Optimization on `ByteOutputStream::appendBool` does not show significant gain in the query in example (because they are a lot small batches), but it is net gain and would be significant in large batches, so I leave it in the code. Reviewed By: xiaoxmeng Differential Revision: D67742489 fbshipit-source-id: 8e70dd128f31caa7909ed7c1e2b4ac1e59d7c87d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
More than 10% of the CPU are spent on the destruction of local partition output when the load is high.
Also add some optimizations for serialization.
Differential Revision: D67742489