test: Make tests compatible with yarl 1.9.5+ #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With yarl 1.9.5 release, the tests would start failing. Changelog: https://yarl.aio-libs.org/en/latest/changes/#id26 TL;DR, the :0 would get eaten and the mock would not intercept the http calls. Tested this manually with 1.9.4 and 1.9.5. The next diff which is part of facebookincubator#59 will confirm I did not screw up. Signed-off-by: Manu Bretelle <chantr4@gmail.com>
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
cc @theihor |
|
Example error stack: https://gist.github.com/chantra/5bdc392c74418d306489df09239de314 |
|
This pull request has been merged in baa42d2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With yarl 1.9.5 release, the tests would start failing.
Changelog: https://yarl.aio-libs.org/en/latest/changes/#id26
TL;DR, the :0 would get eaten and the mock would not intercept the http calls.
Tested this manually with 1.9.4 and 1.9.5.
The next diff which is part of #59 will confirm I did not screw up.