Enable cross-compilation for musl on linux #339
Conversation
|
Hi @stemann! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
stemann
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -198,7 +199,7 @@ static int getInterfaceSpeedGLinkSettings(int sock, struct ifreq* ifr) { | |||
| } ecmd; | |||
| int rv; | |||
|
|
|||
| ifr->ifr_data = (__caddr_t)&ecmd; | |||
| ifr->ifr_data = (caddr_t)&ecmd; | |||
There was a problem hiding this comment.
Okay, the Linux kernel defines this field as char *, probably for ergonomics ... https://lists.freebsd.org/pipermail/freebsd-questions/2006-August/128784.html
/opt/ai/pytorch/third_party/gloo/gloo/common/linux.cc:201:19: error: invalid conversion from 'void*' to 'char*' [-fpermissive]
201 | ifr->ifr_data = (void *)&ecmd;
| ^~~~~~~~~~~~~
| |
| void*
/opt/ai/pytorch/third_party/gloo/gloo/common/linux.cc: In function 'int gloo::getInterfaceSpeedGSet(int, ifreq*)':
/opt/ai/pytorch/third_party/gloo/gloo/common/linux.cc:229:19: error: invalid conversion from 'void*' to 'char*' [-fpermissive]
229 | ifr->ifr_data = (void *)&edata;
| ^~~~~~~~~~~~~~
| |
| void*
This patch was necessary to enable cross-compilation for *-linux-musl
Cf. JuliaPackaging/Yggdrasil#5352