Support JArrayClass without ::javaobject and document its use #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Change the static_assert to allow JavaClass types. - Change pointer cast in getElement to use JniType. - In setElement, use new toPlainJniReference that converts JavaClass values to plain JNI references using ReprAccess. - NOTE: Maybe we should do this last one in JMethod::operator() as well, since it currently passes JavaClass values directly to env->Invoke* Test Plan: CI
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@dreiss has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to facebookarchive/profilo
that referenced
this pull request
Oct 28, 2019
Summary: - Change the static_assert to allow JavaClass types. - Change pointer cast in getElement to use JniType. - In setElement, use new toPlainJniReference that converts JavaClass values to plain JNI references using ReprAccess. - NOTE: Maybe we should do this last one in JMethod::operator() as well, since it currently passes JavaClass values directly to env->Invoke* Pull Request resolved: facebookincubator/fbjni#20 Test Plan: CI Reviewed By: mhorowitz Differential Revision: D18121242 Pulled By: dreiss fbshipit-source-id: 634e92ab55a3bbf05efac5ac61193fb27f4d1445
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 28, 2019
Summary: - Change the static_assert to allow JavaClass types. - Change pointer cast in getElement to use JniType. - In setElement, use new toPlainJniReference that converts JavaClass values to plain JNI references using ReprAccess. - NOTE: Maybe we should do this last one in JMethod::operator() as well, since it currently passes JavaClass values directly to env->Invoke* Pull Request resolved: facebookincubator/fbjni#20 Test Plan: CI Reviewed By: mhorowitz Differential Revision: D18121242 Pulled By: dreiss fbshipit-source-id: 634e92ab55a3bbf05efac5ac61193fb27f4d1445
EduardoCostaom
pushed a commit
to EduardoCostaom/profilo
that referenced
this pull request
Nov 2, 2022
Summary: - Change the static_assert to allow JavaClass types. - Change pointer cast in getElement to use JniType. - In setElement, use new toPlainJniReference that converts JavaClass values to plain JNI references using ReprAccess. - NOTE: Maybe we should do this last one in JMethod::operator() as well, since it currently passes JavaClass values directly to env->Invoke* Pull Request resolved: facebookincubator/fbjni#20 Test Plan: CI Reviewed By: mhorowitz Differential Revision: D18121242 Pulled By: dreiss fbshipit-source-id: 634e92ab55a3bbf05efac5ac61193fb27f4d1445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
values to plain JNI references using ReprAccess.
since it currently passes JavaClass values directly to env->Invoke*
Test Plan:
CI