Documentation to help windows contributors #2841
Conversation
Hopefully encourages devs on Windows machine to contribute
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It would be much easier if this PR #2280 was merged |
|
@cr101 if that was the only file which caused issue, I would see both these PRs as an either or. #2280 --> First step of possibly many to enable cross platform development. |
|
I started an aggregated issue over at #2855 to help us suggest and track improvements for Windows based contributors. Cheers! |
|
I just merged #2309. Will merge this too now but let me know if any info is outdated. |
|
Thanks for merging it! To the best of my knowledge, the info is still valid. I just got a vanilla machine and will test the steps, will correct them if needed. |
|
Amazing, thanks! Please test on the |
* Added documentation for contributors using windows 10 Hopefully encourages devs on Windows machine to contribute * corrected the wordings a little
This PR is in follow up to the discussion in issue #2828
This introduces a new section in contributing.md for developers using windows machine to help them contribute to this project without relying on workarounds.
Tests:
Below are the screenshot that shows that the steps followed enable devs to use the scripts in the repo as is:
Running Prettier
This shows that windows bash is able to understand unix based paths and patterns without any changes.
Running .sh scripts in tasks folder
This shows that windows bash is able to run the scripts out of the box.