-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port cra.sh development task to javascript #2309
Conversation
@ianschmitz Thank you for this PR. A much-needed improvement for the Windows users.
However, after I upgraded Yarn to the current stable version 0.24.5 it then worked fine. |
Yes I found that same behavior as well @cr101. I was running yarn 0.23.4. I mentioned it in the code review. Latest stable fixed it for me |
@gaearon I've been using this change on my local Windows 10 dev machine for a couple of months now and it works great. Can this be merged please? |
The part I was hoping to get a review on was if the |
Seems like this has been used for a while now with good success. Can we get this in soonish? :) |
@Timer this is the PR you mentioned. Can confirm this works 👍 |
Use absolute path when generating .tgz path
I just rebased and updated the license comment. Thoughts on the error output? @Timer? |
I think the error is fine; this is for local devs so the more information the better. An end user will never see it. |
* Port cra.sh development task to javascript * Port cra.sh development task to javascript Use absolute path when generating .tgz path
I've ported
tasks/cra.sh
to javascript to make it easier for contributors on Windows based systems to run an end to end create-react-app CLI workflow as discussed in #2280.If someone more familiar with proper handling of child processes and signal events could take a close look that would be much appreciated!
I've tested on Windows 10 using both npm and yarn in Command Prompt, PowerShell and Git Bash.