Fix memory leak in asyncio awaiter tracking

Summary: The bug was incorrectly marking a coroutine as awaiting itself, causing a loop which could never be GC'd. This only happened when executing the bytecode `SEND_GEN` which is a specialized variant of `SEND`. This is why this issue may have gone unnoticed in tests - the bug only kicks in after the interpreter has time to adapt bytecodes. Reviewed By: itamaro, martindemello Differential Revision: D65434238 fbshipit-source-id: 01e7b0df51c69eb851ba27e22e05bc85dfeb6ff8
facebookincubator · Nov 5, 2024 · 20d2153 · 20d2153
1 parent 34d2cc3
commit 20d2153
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -886,7 +886,7 @@ dummy_func(
             STAT_INC(SEND, hit);
             if ((frame->owner == FRAME_OWNED_BY_GENERATOR) &&
                 (frame->f_code->co_flags & (CO_COROUTINE | CO_ASYNC_GENERATOR))) {
-                Ci_PyAwaitable_SetAwaiter(receiver, (PyObject *)gen);
+                Ci_PyAwaitable_SetAwaiter(receiver, (PyObject *) _PyFrame_GetGenerator(frame));
             }
             _PyInterpreterFrame *gen_frame = (_PyInterpreterFrame *)gen->gi_iframe;
             frame->return_offset = oparg;

diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h