Added sparse blendshape support #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the --blend-shape-sparse flag, FBX2glTF now correctly computes sparse arrays for blendshape storage, which seems to reduce the output file size by anywhere from 60-90%, particularly with large numbers of minimally different blendshapes.
gltf_validator seems perfectly happy with the sparse files and they load into various viewers fine.
Meshes with multiple primitives can generate empty accessors, however, such as when the blendshape is applied to one of the other primitives in the mesh, in this case a single element dummy bufferview gets used, since an accessor's sparse count has to be greater than 0 and the number of accessors has to match the number of morph targets.
Without the --blend-shape-sparse flag, FBX2glTF should operate exactly as before, he said, optimistically.
Also fixed the duplication of target names in the mesh.extras.targetNames array.