Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Double Sided Material and fix image file close issue #226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanlinRL
Copy link

The material has the "isDoubleSided" bool parameter. Because some models have double-sided texture settings, the new bool parameter is added to determine whether Gltf 'doubleSided' is enabled. The default value of this parameter is false.

The material has the "isDoubleSided" bool parameter. Because some models have double-sided texture settings, the new bool parameter is added to determine whether Gltf 'doubleSided' is enabled. The default value of this parameter is false.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

After file is opened, add fclose to avoid saving buffer data in memory
@seanlinRL seanlinRL changed the title Support Double Sided Material Support Double Sided Material and fix image file close issue Sep 16, 2019
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@seanlinRL
Copy link
Author

I think this commit which can support double sided material and fix image file close issue.
So far, I do not seem to have received word from you......
If anyone has any questions feel free to email me: seanlin@reallusion.com.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants