Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update window title for profiling builds #141

Merged

Conversation

huntie
Copy link

@huntie huntie commented Nov 28, 2024

Summary

Note

Depends on #138, #139, and #140.

Extends profiling build behaviour to add a [PROFILING] segment to the window title.

Additionally:

  • Formalises window title mutations in FuseboxWindowTitleManager.
  • Renames and breaks out FuseboxAppMetadataObserver into its own module.

(This also completes the current set of refactors to modularise and simplify rn_fusebox.ts.)

Test plan

image
  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@huntie huntie requested a review from robhogan November 28, 2024 13:56
@huntie huntie force-pushed the profiling-build-window-title branch from d3cce3d to 3ee851e Compare December 2, 2024 12:07
@huntie huntie force-pushed the profiling-build-window-title branch from 3ee851e to 7af489a Compare December 2, 2024 12:10
@huntie huntie merged commit 486803f into facebookexperimental:main Dec 2, 2024
2 checks passed
@huntie huntie deleted the profiling-build-window-title branch December 2, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants