New workflow to deploy the lambda function #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
obbardc
suggested changes
Feb 16, 2022
|
we should probably explain what secrets need to be added too |
added 2 commits
March 9, 2022 09:11
Signed-off-by: Gustavo Noronha Silva <gustavo.noronha@collabora.com>
Triggered when new releases are tagged or manually. Signed-off-by: Gustavo Noronha Silva <gustavo.noronha@collabora.com>
explain where? I can add it to the doc on deploying the lambda function I guess, after it has been validated |
davide125
requested changes
May 30, 2023
davide125
reviewed
May 30, 2023
davide125
reviewed
Jun 1, 2023
Signed-off-by: Santosh Mahto <santosh.mahto@collabora.com>
Signed-off-by: Santosh Mahto <santosh.mahto@collabora.com>
davide125
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the lambda function, package it as expected by AWS lambda, then update it on AWS.
For now this is only triggered manually, so that the update can be performed only when it makes sense to the developers. In the future we can make a release being tagged trigger this workflow.