Merge pull request #249 from htejun/misc

bench: ignore bench updates in study mode
facebookexperimental · Aug 23, 2021 · ebd59bc · ebd59bc
2 parents 5b70362 + 6957646
commit ebd59bc
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/resctl-bench/src/base.rs b/resctl-bench/src/base.rs
@@ -218,9 +218,12 @@ impl<'a> Base<'a> {
 
     fn apply_bench_knobs(&mut self, knobs: BenchKnobs, commit: bool) -> Result<()> {
         self.bench_knobs = knobs;
-        self.save_bench_knobs(&self.bench_knobs_path)?;
-        if commit {
-            self.save_bench_knobs(&self.demo_bench_knobs_path)?;
+        // bench_knobs_path is not set in study mode. Ignore.
+        if self.bench_knobs_path.len() > 0 {
+            self.save_bench_knobs(&self.bench_knobs_path)?;
+            if commit {
+                self.save_bench_knobs(&self.demo_bench_knobs_path)?;
+            }
         }
         Ok(())
     }