This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Use RCTComponentEvent #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oups 🤦♂️ I thought you wanted to land this before [facebook/react-native#15894], might want to revert unless we're not planning to do a release of fbsdk for a while. |
|
No problem. I’m looking into cutting a release soon, but if that PR gets merged and picked into 0.59 the timing might work out alright. |
redcancode
added a commit
to redcancode/react-native-fbsdk
that referenced
this pull request
Jun 15, 2019
This reverts commit 3eb205e.
redcancode
added a commit
to redcancode/react-native-fbsdk
that referenced
this pull request
Jun 17, 2019
This reverts commit 3eb205e.
mdaines-root
added a commit
to Root-App/react-native-fbsdk
that referenced
this pull request
Oct 30, 2019
This reverts commit 3eb205e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to facebook/react-native#15894
Use RCTComponentEvent instead of the deprecated [sendInputEventWithName:body:] which will be removed when facebook/react-native#15894 lands.
This PR should only be merged once facebook/react-native#15894 has landed and made it to a stable release, since RCTComponentEvent does not currently exist in RN master.