Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Fix demo for Android #326

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

javiercr
Copy link
Contributor

The sample demo was failing in Android with this error:

~/react-native-fbsdk/sample/HelloFacebook/android/app/src/main/java/com/hellofacebook/MainApplication.java:59: error: getUseDeveloperSupport() in <anonymous com.hellofacebook.MainApplication$1> cannot override getUseDeveloperSupport() in ReactNativeHost
    protected boolean getUseDeveloperSupport() {
                      ^
  attempting to assign weaker access privileges; was public

That method was changed from protected to public here.

This PR fixes it :)

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@dzhuowen
Copy link
Contributor

Thanks for the PR!

@dzhuowen dzhuowen merged commit 246d92e into facebookarchive:master May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants