Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

upgrades react version to 0.10.0 and bumps react-meteor version to 0.6 #15

Merged
merged 2 commits into from
Mar 29, 2014

Conversation

Spendar89
Copy link
Contributor

Should be self explanatory. I've got it working locally.

@benjamn
Copy link
Contributor

benjamn commented Mar 28, 2014

I'm getting errors on startup because v0.10 of react-tools no longer exports a .React property, so this line from src/require-react.js leaves the global React variable undefined:

React = Npm.require("react-tools").React;

Do you see that in a fresh checkout on your machine?

@Spendar89
Copy link
Contributor Author

Sorry, its working now. Had to change require("react-tools") to require("react"), which returns the proper React obj

@Spendar89
Copy link
Contributor Author

For more info: facebook/react#1114

@benjamn
Copy link
Contributor

benjamn commented Mar 29, 2014

Still need to depend on those packages in package.js, but I'll push some additional commits to fix that.

benjamn added a commit that referenced this pull request Mar 29, 2014
upgrades react version to 0.10.0 and bumps react-meteor version to 0.6
@benjamn benjamn merged commit a5c0b73 into facebookarchive:master Mar 29, 2014
This was referenced Mar 29, 2014
@Spendar89
Copy link
Contributor Author

@benjamn cool looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants