This repository has been archived by the owner on May 24, 2019. It is now read-only.
Upgrade babylon to v7 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks @mourner and apologies for how long it's taken us to look at this. The current plan for v2 of this package is to switch to the actual Flow parser rather than upgrade to Babel v7, and ultimately to use |
|
@motiz88 That sounds great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babylon v7 is WAY faster than the currently used version, and parsing to AST takes almost the whole time of
remove-flow-types, so this upgrade would make all bundles that use this package much faster (e.g. it shaves off 400-500ms off the mapbox-gl-js bundle).Babel v7 is nearing release and babylon@next is very stable (and fixes a huge bunch of issues), so I think it's safe to upgrade despite the beta status. No problem if you want to wait for the final release though.