-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
@agarwalrounak Changes looks good to me. Thanks for your contribution 🎉 |
Draft.js uses immutable 3.7.x. We should link to the docs for that version, otherwise the'll be confusion. https://github.com/facebook/draft-js/blob/268ece35025ecc280282a5169a0a4620f00e3371/package.json#L39 |
Hmm, I'd merge this PR if it linked to an old version of the docs through the Internet Archive. IMO it's the best option we have. |
Draft.js uses immutable 3.7.4 which released on 18 Jun 2015 according to this commit immutable-js/immutable-js@09f04e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Looks good to me, thank you both for converging towards a meaningful solution 👍 |
Summary: **Summary** Record in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirects to https://immutable-js.github.io/immutable-js/ However, the correct link for Record is https://immutable-js.github.io/immutable-js/docs/#/Record Pull Request resolved: facebookarchive/draft-js#2418 Reviewed By: elboman, claudiopro Differential Revision: D22785904 Pulled By: mrkev fbshipit-source-id: 225dedb2198b7e11023c2aa7eed75901d7c558bf
Summary
Record in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirects to https://immutable-js.github.io/immutable-js/
However, the correct link for Record is https://immutable-js.github.io/immutable-js/docs/#/Record