Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update webpack deps #2310

Closed
wants to merge 1 commit into from
Closed

Update webpack deps #2310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,12 @@ var COPYRIGHT_HEADER = `/**
*/
`;

var wpack = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we rename this wpStream? I think it would be easier to reason about


var buildDist = function(opts) {
if (wpack !== null) {
return wpack;
}
var webpackOpts = {
externals: {
immutable: {
Expand Down Expand Up @@ -115,14 +120,15 @@ var buildDist = function(opts) {
if (!opts.debug) {
webpackOpts.plugins.push(new UglifyJsPlugin());
}
return webpackStream(webpackOpts, null, function(err, stats) {
wpack = webpackStream(webpackOpts, null, function(err, stats) {
if (err) {
throw new gulpUtil.PluginError('webpack', err);
}
if (stats.compilation.errors.length) {
gulpUtil.log('webpack', '\n' + stats.toString({colors: true}));
}
});
return wpack;
};

gulp.task(
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"gulp-flatten": "^0.4.0",
"gulp-header": "^2.0.9",
"gulp-if": "^3.0.0",
"gulp-rename": "^1.4.0",
"gulp-rename": "2",
"gulp-util": "^3.0.6",
"jest": "^24.9.0",
"prettier": "1.19.1",
Expand All @@ -80,8 +80,8 @@
"react-test-renderer": "^16.0.0",
"stats-webpack-plugin": "^0.6.2",
"through2": "^3.0.1",
"uglifyjs-webpack-plugin": "^1.1.6",
"webpack-stream": "^4.0.0"
"uglifyjs-webpack-plugin": "2",
"webpack-stream": "5.2.1"
},
"devEngines": {
"node": "10.x || 12.x || 13.x",
Expand Down