This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix isHTMLBRElement test #2278
Closed
Fix isHTMLBRElement test #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@yangshun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Good catch, thanks @yangshun! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 10, 2019
Summary: **Summary** Saw that the Travis CI is failing because of a new test (`isHTMLBRElement`) which did not explicitly disable auto mocking. In Sandcastle, Jest tests aren't automocked hence the tests passed internally but is failing on GitHub. Since all the tests in the repo have `jest.disableAutomock()`, there's no value in having `automock: true` within `package.json`, we can remove it and save ourselves of this config discrepancy and further pain in future. If we decide to go with this approach then #2278 can be abandoned/closed. **Test Plan** Travis CI should pass. Also check that Sandcastle passes. Pull Request resolved: #2279 Reviewed By: mrkev Differential Revision: D18874249 Pulled By: yangshun fbshipit-source-id: e371558552728b395f67bf1c4d94b127cc3c2c96
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** In the Facebook repo mirror, modules in Jest tests are not mocked, but on GitHub they are (as seen from `package.json`). That led to D18831442 passing internally in Sandcastle but failing on Travis. Not a huge deal, we can just add `jest.disableAutomock()`. We might want to see if we can remove `"automock": true,` from the Jest config in `package.json` to have a more similar environment to Facebook's Jest config. **Test Plan** Travis CI should pass now. Pull Request resolved: facebookarchive#2278 Differential Revision: D18874041 Pulled By: yangshun fbshipit-source-id: 282c137934dea27259a2b52741c749fb6c332323
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** Saw that the Travis CI is failing because of a new test (`isHTMLBRElement`) which did not explicitly disable auto mocking. In Sandcastle, Jest tests aren't automocked hence the tests passed internally but is failing on GitHub. Since all the tests in the repo have `jest.disableAutomock()`, there's no value in having `automock: true` within `package.json`, we can remove it and save ourselves of this config discrepancy and further pain in future. If we decide to go with this approach then facebookarchive#2278 can be abandoned/closed. **Test Plan** Travis CI should pass. Also check that Sandcastle passes. Pull Request resolved: facebookarchive#2279 Reviewed By: mrkev Differential Revision: D18874249 Pulled By: yangshun fbshipit-source-id: e371558552728b395f67bf1c4d94b127cc3c2c96
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** In the Facebook repo mirror, modules in Jest tests are not mocked, but on GitHub they are (as seen from `package.json`). That led to D18831442 passing internally in Sandcastle but failing on Travis. Not a huge deal, we can just add `jest.disableAutomock()`. We might want to see if we can remove `"automock": true,` from the Jest config in `package.json` to have a more similar environment to Facebook's Jest config. **Test Plan** Travis CI should pass now. Pull Request resolved: facebookarchive#2278 Differential Revision: D18874041 Pulled By: yangshun fbshipit-source-id: 282c137934dea27259a2b52741c749fb6c332323
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** Saw that the Travis CI is failing because of a new test (`isHTMLBRElement`) which did not explicitly disable auto mocking. In Sandcastle, Jest tests aren't automocked hence the tests passed internally but is failing on GitHub. Since all the tests in the repo have `jest.disableAutomock()`, there's no value in having `automock: true` within `package.json`, we can remove it and save ourselves of this config discrepancy and further pain in future. If we decide to go with this approach then facebookarchive#2278 can be abandoned/closed. **Test Plan** Travis CI should pass. Also check that Sandcastle passes. Pull Request resolved: facebookarchive#2279 Reviewed By: mrkev Differential Revision: D18874249 Pulled By: yangshun fbshipit-source-id: e371558552728b395f67bf1c4d94b127cc3c2c96
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** In the Facebook repo mirror, modules in Jest tests are not mocked, but on GitHub they are (as seen from `package.json`). That led to D18831442 passing internally in Sandcastle but failing on Travis. Not a huge deal, we can just add `jest.disableAutomock()`. We might want to see if we can remove `"automock": true,` from the Jest config in `package.json` to have a more similar environment to Facebook's Jest config. **Test Plan** Travis CI should pass now. Pull Request resolved: facebookarchive/draft-js#2278 Differential Revision: D18874041 Pulled By: yangshun fbshipit-source-id: 282c137934dea27259a2b52741c749fb6c332323
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the Facebook repo mirror, modules in Jest tests are not mocked, but on GitHub they are (as seen from
package.json). That led to D18831442 passing internally in Sandcastle but failing on Travis. Not a huge deal, we can just addjest.disableAutomock().We might want to see if we can remove
"automock": true,from the Jest config inpackage.jsonto have a more similar environment to Facebook's Jest config.Test Plan
Travis CI should pass now.