This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix when anchorNode is undefined instead of null #1407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes facebookarchive#1399 `nativeSelection.anchorNode` can be undefined instead of null, so I'm changing the condition to handle this use case.
flarnie
approved these changes
Oct 3, 2017
| @@ -155,7 +155,7 @@ function editOnBeforeInput( | |||
| const nativeSelection = global.getSelection(); | |||
| // Selection is necessarily collapsed at this point due to earlier check. | |||
| if ( | |||
| nativeSelection.anchorNode !== null && | |||
| nativeSelection.anchorNode && | |||
There was a problem hiding this comment.
I generally prefer to be more specific when checking for a value to be defined, but in this case we don't want any other falsy JS values either, so I think this is ok.
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
In what situation can anchorNode be undefined? |
|
@sophiebits You can see an example in #1399 when using Enzyme. But I don't have access to that specific bit of code to really investigate why |
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
Summary: Fixes #1399 `nativeSelection.anchorNode` can be undefined instead of null, so I'm changing the condition to handle this use case. Closes facebookarchive/draft-js#1407 Differential Revision: D5974852 fbshipit-source-id: bb24ba0e3bf041530bdbea555f26e61d2b33022f
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Fixes #1399 `nativeSelection.anchorNode` can be undefined instead of null, so I'm changing the condition to handle this use case. Closes facebookarchive/draft-js#1407 Differential Revision: D5974852 fbshipit-source-id: bb24ba0e3bf041530bdbea555f26e61d2b33022f
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: Fixes #1399 `nativeSelection.anchorNode` can be undefined instead of null, so I'm changing the condition to handle this use case. Closes facebookarchive/draft-js#1407 Differential Revision: D5974852 fbshipit-source-id: bb24ba0e3bf041530bdbea555f26e61d2b33022f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1399
nativeSelection.anchorNodecan be undefined instead of null, so I'm changing the condition to handle this use case.