Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update comments in editOnInput.js #1085

Closed
flarnie opened this issue Mar 17, 2017 · 3 comments
Closed

Update comments in editOnInput.js #1085

flarnie opened this issue Mar 17, 2017 · 3 comments

Comments

@flarnie
Copy link
Contributor

flarnie commented Mar 17, 2017

The inline comments about editOnInput are no longer accurate - this method is called on every keystroke and is the main way that we update editorState ever since 07892ba

If you're trying to understand how events are handled and updates are processed in Draft.js this could be a good first bug.

@morrme
Copy link

morrme commented Mar 27, 2017

I'm new but I'd like to help.

@flarnie
Copy link
Contributor Author

flarnie commented Jul 22, 2017

Hi @morrme - thanks for commenting. Were you still interested in this? Any questions?

@flarnie flarnie self-assigned this Jul 22, 2017
@itssujan
Copy link
Contributor

itssujan commented Nov 8, 2017

@flarnie if this is still open, I can take a stab..

jdecked pushed a commit to twitter-forks/draft-js that referenced this issue Oct 9, 2019
…acebookarchive#2132)

Summary:
Fixes facebookarchive#1085

Updated the comment describing the `onEditInput` event handler function.
Pull Request resolved: facebookarchive#2132

Reviewed By: mitermayer

Differential Revision: D16545276

Pulled By: mrkev

fbshipit-source-id: 4f2f4263f9ee63d8c468f8f07ff0b30d9793fccb
mmissey pushed a commit to mmissey/draft-js that referenced this issue Mar 24, 2020
…acebookarchive#2132)

Summary:
Fixes facebookarchive#1085

Updated the comment describing the `onEditInput` event handler function.
Pull Request resolved: facebookarchive#2132

Reviewed By: mitermayer

Differential Revision: D16545276

Pulled By: mrkev

fbshipit-source-id: 4f2f4263f9ee63d8c468f8f07ff0b30d9793fccb
alicayan008 pushed a commit to alicayan008/draft-js that referenced this issue Jul 4, 2023
…#2132)

Summary:
Fixes facebookarchive/draft-js#1085

Updated the comment describing the `onEditInput` event handler function.
Pull Request resolved: facebookarchive/draft-js#2132

Reviewed By: mitermayer

Differential Revision: D16545276

Pulled By: mrkev

fbshipit-source-id: 4f2f4263f9ee63d8c468f8f07ff0b30d9793fccb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants