This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update comments in editOnInput.js
#1085
Labels
Comments
I'm new but I'd like to help. |
Hi @morrme - thanks for commenting. Were you still interested in this? Any questions? |
@flarnie if this is still open, I can take a stab.. |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this issue
Oct 9, 2019
…acebookarchive#2132) Summary: Fixes facebookarchive#1085 Updated the comment describing the `onEditInput` event handler function. Pull Request resolved: facebookarchive#2132 Reviewed By: mitermayer Differential Revision: D16545276 Pulled By: mrkev fbshipit-source-id: 4f2f4263f9ee63d8c468f8f07ff0b30d9793fccb
This was referenced Oct 9, 2019
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this issue
Mar 24, 2020
…acebookarchive#2132) Summary: Fixes facebookarchive#1085 Updated the comment describing the `onEditInput` event handler function. Pull Request resolved: facebookarchive#2132 Reviewed By: mitermayer Differential Revision: D16545276 Pulled By: mrkev fbshipit-source-id: 4f2f4263f9ee63d8c468f8f07ff0b30d9793fccb
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this issue
Jul 4, 2023
…#2132) Summary: Fixes facebookarchive/draft-js#1085 Updated the comment describing the `onEditInput` event handler function. Pull Request resolved: facebookarchive/draft-js#2132 Reviewed By: mitermayer Differential Revision: D16545276 Pulled By: mrkev fbshipit-source-id: 4f2f4263f9ee63d8c468f8f07ff0b30d9793fccb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The inline comments about
editOnInput
are no longer accurate - this method is called on every keystroke and is the main way that we update editorState ever since 07892baIf you're trying to understand how events are handled and updates are processed in Draft.js this could be a good first bug.
The text was updated successfully, but these errors were encountered: