Make some more modules strict-local

Summary: Only change to logic involved not modifying an argument (since arguments are constant in flow strict). Also fixes a lint (newline missing). Reviewed By: gkz Differential Revision: D18329130 fbshipit-source-id: 79007c6591cb9e0398924801496d580715aca7b4
facebookarchive · Jan 30, 2020 · c30ca73 · c30ca73
1 parent 7002565
commit c30ca73
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/src/model/transaction/__tests__/ContentStateInlineStyle-test.js b/src/model/transaction/__tests__/ContentStateInlineStyle-test.js
@@ -89,8 +89,8 @@ test('must remove styles', () => {
 test('must add and remove styles accross multiple blocks', () => {
   const nextBlock = contentState.getBlockAfter(selectionState.getStartKey());
   const selection = selectionState.merge({
-    focusKey: nextBlock.getKey(),
-    focusOffset: nextBlock.getLength(),
+    focusKey: nextBlock?.getKey(),
+    focusOffset: nextBlock?.getLength(),
   });
 
   const modified = assertAddContentStateInlineStyle('BOLD', selection);

diff --git a/src/model/transaction/__tests__/applyEntityToContentState-test.js b/src/model/transaction/__tests__/applyEntityToContentState-test.js
@@ -31,8 +31,8 @@ const selectBlock = new SelectionState({
 const selectAdjacentBlocks = new SelectionState({
   anchorKey: initialBlock.getKey(),
   anchorOffset: 0,
-  focusKey: secondBlock.getKey(),
-  focusOffset: secondBlock.getLength(),
+  focusKey: secondBlock?.getKey(),
+  focusOffset: secondBlock?.getLength(),
 });
 
 const assertApplyEntityToContentState = (

diff --git a/src/model/transaction/applyEntityToContentBlock.js b/src/model/transaction/applyEntityToContentBlock.js
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @format
- * @flow
+ * @flow strict-local
  * @emails oncall+draft_js
  */
 
@@ -17,10 +17,11 @@ const CharacterMetadata = require('CharacterMetadata');
 
 function applyEntityToContentBlock(
   contentBlock: BlockNodeRecord,
-  start: number,
+  startArg: number,
   end: number,
   entityKey: ?string,
 ): BlockNodeRecord {
+  let start = startArg;
   let characterList = contentBlock.getCharacterList();
   while (start < end) {
     characterList = characterList.set(

diff --git a/src/model/transaction/getSampleStateForTesting.js b/src/model/transaction/getSampleStateForTesting.js
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @format
- * @flow
+ * @flow strict-local
  * @emails oncall+draft_js
  */
 
@@ -97,7 +97,11 @@ const contentState = new ContentState({
 let editorState = EditorState.createWithContent(contentState);
 editorState = EditorState.forceSelection(editorState, selectionState);
 
-const getSampleStateForTesting = (): Object => {
+const getSampleStateForTesting = (): {|
+  editorState: EditorState,
+  contentState: ContentState,
+  selectionState: SelectionState,
+|} => {
   return {editorState, contentState, selectionState};
 };
 

diff --git a/src/model/transaction/updateEntityDataInContentState.js b/src/model/transaction/updateEntityDataInContentState.js
@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @format
- * @flow
+ * @flow strict-local
  * @emails oncall+draft_js
  */
 
@@ -16,7 +16,7 @@ import type ContentState from 'ContentState';
 function updateEntityDataInContentState(
   contentState: ContentState,
   key: string,
-  data: {[key: string]: any, ...},
+  data: {[key: string]: mixed, ...},
   merge: boolean,
 ): ContentState {
   const instance = contentState.getEntity(key);