Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Commit

Permalink
Prevent placeholder from unnecessarily wrapping (#2392)
Browse files Browse the repository at this point in the history
Summary:
In Safari, the placeholder text sometimes wraps into multiple lines before it reaches the full width of the editor.
The addition of `width: 100%;` prevents the absolutely-positioned placeholder from trying to "shrink-wrap", which causes the unnecessarily wrapping.
Steps to reproduce:
1. Open the editor with a placeholder that takes up >50% but <100% of the editor width in Safari.
2. Type a character.
3. Press backspace.

*Before* submitting a pull request, please make sure the following is done...

1. Fork the repo and create your branch from `master`.
2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation.
4. Ensure that:
  * The test suite passes (`npm test`)
  * Your code lints (`npm run lint`) and passes Flow (`npm run flow`)
  * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests)
5. If you haven't already, complete the [CLA](https://code.facebook.com/cla).

Please use the simple form below as a guideline for describing your pull request.

Thanks for contributing to Draft.js!

-

**Summary**

[...]

**Test Plan**

[...]
Pull Request resolved: #2392

Reviewed By: fryn

Differential Revision: D21319038

Pulled By: mrkev

fbshipit-source-id: b03c8afa47873ea210207aadb0225db8801bd84e
  • Loading branch information
fryn authored and facebook-github-bot committed May 1, 2020
1 parent 9028881 commit 9d6bbfd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/component/base/DraftEditorPlaceholder.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
.public/DraftEditorPlaceholder/root {
color: var(fig-secondary-text);
position: absolute;
width: 100%;
z-index: 1;
}

Expand Down

0 comments on commit 9d6bbfd

Please sign in to comment.