This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
[guppy-summaries] make metadata a dynamic toml value #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that the same library can parse summaries created by both old and new versions of guppy. We don't use the summary for much anyway, currently. I also looked at switching to `toml_edit`, which has a much better design overall. Unfortunately, I ran into toml-rs/toml#192. It makes sense to switch to `toml_edit` at some point in the future, and I've filed facebookarchive#492 to keep track of that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that the same library can parse summaries created by both old
and new versions of guppy. We don't use the summary for much anyway,
currently.
I also looked at switching to
toml_edit, which has a much betterdesign overall. Ran into a couple of issues, but eventually it makes sense to switch
to
toml_editat some point in the future. I've filed facebookincubator#492 to keeptrack of that.