This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Add arm64 x86_64 support #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ee6e7e3)
This was referenced Apr 8, 2018
|
How does this PR relate to #19 ? |
|
This pr is based on that pr, you can see the cherry commit from that pr. Besides that I fix broken url and add ci. |
|
Cool. |
|
The buck change landed: facebook/buck@fe15dae |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 24, 2018
Summary: add arm64 support, related issue : #2814. If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release. RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta. facebookarchive/android-jsc#30. [ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support. Differential Revision: D9491481 Pulled By: hramos fbshipit-source-id: d6ec6992768eb0c0866a0317273e09fae5b8935e
|
facebook/react-native#18754 has been merged. What's next? |
|
Do you have merge permission to this repo ? we may still need a repo to handle jsc thing if we don't adopt the jsc from community. |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: add arm64 support, related issue : facebook/react-native#2814. If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release. RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta. facebookarchive/android-jsc#30. [ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support. Differential Revision: D9491481 Pulled By: hramos fbshipit-source-id: d6ec6992768eb0c0866a0317273e09fae5b8935e
Closed
1 task
3 tasks
|
Is this ever happening? |
|
This PR was opened as part of an effort to add 64-bit library support to React Nartive. We already have 64-bit support in the JSC that is being used by React Native. The JSC used there is built based on a different repository than this. If you’re interested in seeing 64-bit support added to the JSC in this repository for use with something other than React Native, then I probably am not the right person to help. |
|
Well, the android version of React Native currently does not support Javascript Proxy...which is why I was using this JSC. But, this JSC does not work on Android 9 x86_64 devices. |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: add arm64 support, related issue : facebook/react-native#2814. If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release. RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta. facebookarchive/android-jsc#30. [ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support. Differential Revision: D9491481 Pulled By: hramos fbshipit-source-id: d6ec6992768eb0c0866a0317273e09fae5b8935e
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: add arm64 support, related issue : facebook#2814. If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release. RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta. facebookarchive/android-jsc#30. [ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support. Differential Revision: D9491481 Pulled By: hramos fbshipit-source-id: d6ec6992768eb0c0866a0317273e09fae5b8935e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bug in buck need to be fixed: facebook/buck#1836. After they fix it. We need another pr to fix app modules thing.