Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional flag for Visual #2647

Merged
merged 1 commit into from
May 13, 2021

Conversation

senhuang42
Copy link
Contributor

@senhuang42 senhuang42 commented May 13, 2021

Now that ZSTD_DISABLE_DEPRECATE_WARNINGS is in the source code itself, including them in vcxproj files will cause a C4005 macro redefinition warning. So we should remove them to avoid appveyor failures.

Test Plan:

  • Appveyor

@senhuang42
Copy link
Contributor Author

Hmm, appveyor has been queued for over an hour, not sure how to force it to run.

@Cyan4973
Copy link
Contributor

We do have a time-length pb with Appveyor tests.
When one specific test should be run swiftly, best way is to cancel all prior runs queued before.

@senhuang42
Copy link
Contributor Author

senhuang42 commented May 13, 2021

We do have a time-length pb with Appveyor tests.
When one specific test should be run swiftly, best way is to cancel all prior runs queued before.

Ah, it seems like I don't have permissions to cancel any appveyor runs, but the ones on just PRs seem to be a little faster.

@Cyan4973
Copy link
Contributor

Appveyor tests moved towards d3634bf

@senhuang42 senhuang42 merged commit 0671808 into facebook:dev May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants