Add GitHub Action to Automatically Publish Release Tarballs #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a GitHub action that is triggered on release creation, which creates the release tarball, compresses it, hashes it, signs it, and attaches all of those files to the release.
|
This looks good to me! I don't have a strong preference on the tarball names. As long as we aren't changing the old names, it shouldn't be a huge deal to add |
When the tag is `v1.2.3`, name the artifacts `zstd-1.2.3.tar*` rather than `zstd-v1.2.3.tar*`. When the tag doesn't match, use the full tag.
felixhandte
force-pushed
the
gha-release-artifacts
branch
from
d47ae02 to
2303306
Compare
felixhandte
force-pushed
the
gha-release-artifacts
branch
from
2303306 to
d2b7f2e
Compare
terrelln
approved these changes
Mar 15, 2021
|
I think this is fine as an MVP but I really don't like it that this seems to do signing on Github's servers. The keys should be guarded as much as possible - some people even use hardware security keys. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a GitHub action that is triggered on release creation, which creates the release tarball, compresses it, hashes it, signs it, and attaches all of those files to the release.
Here's an example invocation on my repo:
I wanted to also generate the windows artifacts but windows is hard and I gave up.
Because this PR signs the artifacts when a key is provided, this is one step towards addressing #2520.