Node -> Measure func map instead of vec #1581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D53776790 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Feb 22, 2024
Summary: Pull Request resolved: facebook#1581 This is better than just trusting the order of the measure func call. Now each measure function I/O is associated with a node in the JSON. Reviewed By: NickGerleman Differential Revision: D53776790
joevilches
force-pushed
the
export-D53776790
branch
from
1fe5e55 to
95fd543
Compare
Summary: Pull Request resolved: facebook#1581 This is better than just trusting the order of the measure func call. Now each measure function I/O is associated with a node in the JSON. Reviewed By: NickGerleman Differential Revision: D53776790
|
This pull request was exported from Phabricator. Differential Revision: D53776790 |
joevilches
force-pushed
the
export-D53776790
branch
from
95fd543 to
9d517ee
Compare
|
This pull request has been merged in c278713. |
|
This pull request was exported from Phabricator. Differential Revision: D53776790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is better than just trusting the order of the measure func call. Now each measure function I/O is associated with a node in the JSON.
Differential Revision: D53776790