-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add maybe_async_trait
#334
feat: Add maybe_async_trait
#334
Conversation
Hi @igamigo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Had to add various newlines and "summaries" (mostly placeholders, we likely need to replace with better text) to make the first paragraph shorter in doc comments because of failing clippy checks. For the same reason I also had to add a usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! I left a few comments inline - but these are for files not related to this PR. So, we can merge as is and then make updates separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you!
Adds
maybe_async_trait
which adds a way to useasync_trait
based on whether theasync
feature is turned on. The attribute needs to be set for the trait impl and definition blocks. The macro takes functions annotated with#[maybe_async]
, makes them async, and then sets#[async_trait]
.One small consequence of this is that when you have code like this:
If you turn on the
async
feature, thenmaybe_async
becomes an unused import (becausemaybe_async_trait
essentially removes it fromfoo
) which might affect clippy lints. One way to deal with this would be to import macros like this:use winter_maybe_async::*
.