fix: incorrect read_slice impl for ReadAdapter #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
force-pushed
the
bitwalker/readadapter-fix
branch
from
9e1ef23
to
1b1f782
Compare
irakliyk
approved these changes
Sep 6, 2024
This commit fixes a bug that is present in the implementation of ByteReader for ReadAdapter. Specifically, it does not consume any input, so calling `read_slice` and then attempting to read the next value in the input, will read the same bytes again. The documented behavior of this function is that any of the `read_*` methods consume the corresponding amount of input. To catch this, and to prevent future regressions, a new test was added that serializes some data to a file using one approach, and deserializes it using the ReadAdapter. This ensures that we don't accidentally make choices in the writer that aren't matched by the reader, and vice versa. Closes facebook#308
bitwalker
force-pushed
the
bitwalker/readadapter-fix
branch
from
1b1f782
to
ec52b24
Compare
|
@irakliyk Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that is present in the implementation of
ByteReader::read_slicefor ReadAdapter. Specifically, it does not consume any input, so callingread_sliceand then attempting to read the next value in the input, will read the same bytes again. The documented behavior of this function is that any of theread_*methods consume the corresponding amount of input.To catch this, and to prevent future regressions, a new test was added that serializes some data to a file using one approach, and deserializes it using the ReadAdapter. This ensures that we don't accidentally make choices in the writer that aren't matched by the reader, and vice versa.
Closes #308