Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Serializable and Deserializable implementations from slices and vecs #239

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

irakliyk
Copy link
Collaborator

@irakliyk irakliyk commented Jan 4, 2024

This PR removes current implementations of Serializable and Deserilizable traits from slices and vectors. The motivation for this is that the way sterilization worked for these structs was somewhat confusing (slices and vectors were serialized without their lengths). Instead, we can use explicit calls to write_batch() and read_batch() methods to accomplish the same thing.

In the future, we can reimplement Serializable and Deserializable on slices and vecs, but this time we would serialize them together with the number of elements (for which we can use usize serialization implemented in #238).

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion; otherwise LGTM as is

utils/core/src/serde/byte_writer.rs Outdated Show resolved Hide resolved
@irakliyk irakliyk merged commit 5a3cea2 into main Feb 5, 2024
9 checks passed
@irakliyk irakliyk deleted the serialization branch February 5, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants