Remove Serializable
and Deserializable
implementations from slices and vecs
#239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes current implementations of
Serializable
andDeserilizable
traits from slices and vectors. The motivation for this is that the way sterilization worked for these structs was somewhat confusing (slices and vectors were serialized without their lengths). Instead, we can use explicit calls towrite_batch()
andread_batch()
methods to accomplish the same thing.In the future, we can reimplement
Serializable
andDeserializable
on slices and vecs, but this time we would serialize them together with the number of elements (for which we can useusize
serialization implemented in #238).