Allow duplicate query positions #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irakliyk
force-pushed
the
constraint-composition
branch
from
0be4dd2
to
7fbfce7
Compare
irakliyk
force-pushed
the
rejection-sampling
branch
from
c72ef9d
to
3e5b276
Compare
irakliyk
force-pushed
the
rejection-sampling
branch
from
3e5b276
to
9fdbb0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #220 (and as such it also addresses #216). However, the approach taken here is de-duplicate query positions explicitly at the prover and the verifier, rather than doing it implicitly during Merkle path generation.